This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Rewrite buster tests as tape tests #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
semver-patch
Already covered by json- and custom-encoding-test
Member
Author
|
Next up: #273, though for a different reason: to be able to call the test suite on an |
| ;[true, false].forEach(function (encode) { | ||
| ;[true, false].forEach(function (deferredOpen) { | ||
| ;[true, false].forEach(function (delayedPut) { | ||
| makeTest(test, encode, deferredOpen, delayedPut) |
Member
ralphtheninja
left a comment
ralphtheninja
left a comment
There was a problem hiding this comment.
Woha. Nice work! Not going through this in detail, just skimming it.
Member
Author
I completely understand 😉 |
Member
Author
|
Because it's a lot, I'd like to keep the commits, not squash. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #650. Closes #497. WIP. Has two goals:
referee,samsam)abstract-leveldown's, so that they may be merged later on.