fix: require successful tool evidence before Kanban completion - #2
Closed
benperry6 wants to merge 1 commit into
Closed
Conversation
Persist one metadata-only tool receipt per current task run so both native Hermes and Codex app-server workers can prove successful material work before completion. Reject failed results, preserve the running task, and close the cross-process notification race with a bounded read. Co-Authored-By: GPT-5.6 SOL <noreply@openai.com>
Author
|
Superseded by a fresh, standalone current-main commit: The refreshed implementation is based on upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to NousResearch#32940 and issue NousResearch#32746, built directly on this branch.
This changes Kanban completion proof from tool-call intent to successful material execution evidence:
task_events;protocol_violationevent.Verification:
py_compile, andgit diff --checkpassed;The separate product decision about a reasoning-only/no-tool exception remains intentionally with maintainers.
Cherry-pick alternative:
e19ff6c499f0b9832f05af127254c28cc333cf8d.