Merge pull request #32 from LeoAndo/android_lint

Android Lintを実行し、指摘のある箇所の修正
LeoAndo · Dec 31, 2022 · 57debd3 · 57debd3
2 parents 0523ccc + bf1d02c
commit 57debd3
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 16 deletions.
diff --git a/.idea/deploymentTargetDropDown.xml b/.idea/deploymentTargetDropDown.xml
diff --git a/app/src/main/kotlin/jp/co/yumemi/android/codecheck/data/api/response/GithubSearchResponse.kt b/app/src/main/kotlin/jp/co/yumemi/android/codecheck/data/api/response/GithubSearchResponse.kt
@@ -130,10 +130,10 @@ fun GithubSearchResponse.toModel(): List<RepositorySummary> {
             name = it.name,
             ownerIconUrl = it.owner.avatar_url,
             language = it.language.toString(),
-            stargazersCount = it.stargazers_count.toLong(),
-            watchersCount = it.watchers_count.toLong(),
-            forksCount = it.forks_count.toLong(),
-            openIssuesCount = it.open_issues_count.toLong(),
+            stargazersCount = it.stargazers_count,
+            watchersCount = it.watchers_count,
+            forksCount = it.forks_count,
+            openIssuesCount = it.open_issues_count,
         )
     }
 }
diff --git a/app/src/main/kotlin/jp/co/yumemi/android/codecheck/model/RepositorySummary.kt b/app/src/main/kotlin/jp/co/yumemi/android/codecheck/model/RepositorySummary.kt
@@ -8,8 +8,8 @@ data class RepositorySummary(
     val name: String,
     val ownerIconUrl: String,
     val language: String,
-    val stargazersCount: Long,
-    val watchersCount: Long,
-    val forksCount: Long,
-    val openIssuesCount: Long,
+    val stargazersCount: Int,
+    val watchersCount: Int,
+    val forksCount: Int,
+    val openIssuesCount: Int,
 ) : Parcelable
diff --git a/app/src/main/kotlin/jp/co/yumemi/android/codecheck/ui/repository/RepositoryFragment.kt b/app/src/main/kotlin/jp/co/yumemi/android/codecheck/ui/repository/RepositoryFragment.kt
@@ -8,14 +8,12 @@ import android.view.View
 import androidx.fragment.app.Fragment
 import androidx.navigation.fragment.navArgs
 import coil.load
-import dagger.hilt.android.AndroidEntryPoint
 import jp.co.yumemi.android.codecheck.R
 import jp.co.yumemi.android.codecheck.databinding.FragmentRepositoryBinding
 
 /**
  * リポジトリ詳細画面
  */
-@AndroidEntryPoint
 class RepositoryFragment : Fragment(R.layout.fragment_repository) {
 
     private val args: RepositoryFragmentArgs by navArgs()

diff --git a/app/src/main/res/values-v29/themes.xml b/app/src/main/res/values-v29/themes.xml
@@ -1,6 +1,6 @@
-<resources xmlns:tools="http://schemas.android.com/tools">
+<resources>
 
-    <style name="Theme.M3Demo" parent="Base.Theme.AndroidEngineerCodeCheck">
+    <style name="Theme.AndroidEngineerCodeCheck" parent="Base.Theme.AndroidEngineerCodeCheck">
         <!-- Transparent system bars for edge-to-edge. -->
         <item name="android:navigationBarColor">@android:color/transparent</item>
         <item name="android:statusBarColor">@android:color/transparent</item>

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -6,7 +6,6 @@
     <string name="reload">reload</string>
     <string name="empty_message">search result empty.</string>
     <string name="network_error_message">Please check the network status.</string>
-    <string name="no_content_description">No contentDescription</string>
     <string name="content_description_owner_avatar_icon">owner Avatar Icon</string>
     <string name="stargazers_count">%d stars</string>
     <string name="forks_count">%d forks</string>

diff --git a/docs/app.gif b/docs/app.gif
diff --git a/settings.gradle b/settings.gradle
@@ -3,7 +3,6 @@ dependencyResolutionManagement {
     repositories {
         google()
         mavenCentral()
-        jcenter() // Warning: this repository is going to shut down soon
     }
 }
 rootProject.name = "Android Engineer CodeCheck"