Add note wrapper (fixes #2657) #5221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
note-wrapper
branch
from
52251ec
to
f570530
Compare
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
dessalines
reviewed
Nov 22, 2024
dessalines
reviewed
Nov 22, 2024
| @@ -32,12 +32,12 @@ impl Object for ApubNote { | |||
| _object_id: Url, | |||
| _context: &Data<Self::DataType>, | |||
| ) -> LemmyResult<Option<Self>> { | |||
| unimplemented!() | |||
| Err(LemmyErrorType::Unknown("not implemented".to_string()).into()) | |||
There was a problem hiding this comment.
I looked at some of the others, and these all have specific FederationErrors for actions that can't be done. But its up to you there.
Also worth looking into why the unimplemented and todo passed the CI.
There was a problem hiding this comment.
Those other errors can actually occur in production. But the ones here are never be called, they are only relevant when fetching remote objects or sending objects out, neither of which is done with NoteWrapper (sending is done via PrivateMessage/Comment).
There was a problem hiding this comment.
As for the lints not working it seems to be related to async_trait, outside of that it works fine.
dessalines
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private messages and public comments are quite awkward in Activitypub, because the json format looks identical. They only way to differentiate them is to check for the presence or absence of
https://www.w3.org/ns/activitystreams#Publicintoorcc. This PR adds a new wrapper for federated comments and private messages, which allows both to have type Note and handles them appropriately. This means that private messages will be compatible with other Fediverse platforms like Mastodon.It is also backwards compatible with private messages on older Lemmy versions. For receiving it simply accepts the old
ChatMessagetype. For sending, it checks the software and version of the target instance. If it is a Lemmy instance prior to 0.20, aChatMessageis sent, and otherwise aNote.