Add custom migration runner, forbid some diesel migration commands, fix old migrations
#4673
Conversation
dullbananas
changed the title
diesel migration no longer allowed)
dullbananas
changed the title
diesel migration no longer allowed)diesel migration commands no longer allowed)
dullbananas
changed the title
diesel migration commands no longer allowed)diesel migration commands, fix old migrations
|
Sry about being slow to review this, I'd like it to come after the |
…n Cargo.lock` then letting it auto update again
| when: *slow_check_paths | ||
|
|
||
| check_diesel_migration: |
There was a problem hiding this comment.
We can't check / test the migrations anymore in CI?
There was a problem hiding this comment.
This was moved to the unit tests in schema_setup.rs
|
|
||
| const PATTERN_LEN: usize = 19; | ||
|
|
||
| pub fn check_dump_diff(before: String, after: String, label: &str) { |
There was a problem hiding this comment.
Why is so much custom code necessary for checking a diff?
There was a problem hiding this comment.
The added complexity is now in #5204 instead of this PR, and I will try to make the comments more clear about the reason in that PR
| @@ -220,14 +221,36 @@ BEGIN | |||
| post_aggregates_view | |||
| WHERE | |||
| id = NEW.post_id; | |||
| -- Force the hot rank as zero on week-older posts | |||
| -- Update the comment hot_ranks as of last week | |||
| UPDATE | |||
There was a problem hiding this comment.
These are really old migrations that are updating tables and views that aren't used anymore, whats going on?
|
I've wanted to split this PR so the changed diff behavior and the migration changes it requires are separate, but I've been putting it off. I will do that soon. For the migration changes, I now think the diff checker should only check migrations after the migration that removes all views. That should allow removing most of the migration changes. I will work on this for a while after I make the PR with the simpler changes. |
Reverting and testing migrations will be done with
lemmy_server migrationcommands, anddiesel migrationcommands will do nothing and fail when trying to run or revert migrations.Benefits:
All migrations, not just the newest one, will be tested with schema diff(moved to Improve migration diff check and fix old migrations #5204)#4333 (comment)
The new tests (even just reverting all migrations) revealed some mistakes in old migrations, so I fixed those, and I also discovered that'now'::timestampin old views used the timestamp of the view's creation instead of the current timestamp.