-
Notifications
You must be signed in to change notification settings - Fork 48
feat(icon): add time-delay icon #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icon): add time-delay icon #83
Conversation
I paired with @lt83870 (Leo) on this one, but I need to pull it down just to verify the commit. It does also look like something odd happened in the latest version of |
883bd00
to
1cefc0b
Compare
I've done a bit of checking and I think when pulled in the latest version of svg-to-ts we may have inadvertently exposed a breaking change. Each icon set now exports.. However the name is the same across both the Icon and BrandIcon set, hence the error in the build. Possible solutions.
|
I'd say revert the version and then we can look into this a bit better. |
62a44e7
to
ec6ba48
Compare
I've reverted and pinned the working version of svg-to-ts. I've also raised an issue into svg-to-ts just to see if they think it's a legitimate bug or something we should workaround. |
An issue was encountered while updating to the latest version of svg-to-ts, this commit pins it to a specific version. An [issue](nivekcode/svg-to-ts#91) is raised against the svg-to-ts repo, depending on the outcome we can either workaround it locally or help provide a fix.
ec6ba48
to
7eaf814
Compare
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add time-delay icon to Icons folder. Icon provided by @james-hayden-ellis
https://deploy-preview-83--legal-and-general-canopy.netlify.app/?path=/story/components-icon--standard
Checklist: