-
Notifications
You must be signed in to change notification settings - Fork 48
Auto register icons #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elenagarrone
merged 4 commits into
Legal-and-General:master
from
elenagarrone:fep-2796-ar-icons
Jan 16, 2025
Merged
Auto register icons #1499
elenagarrone
merged 4 commits into
Legal-and-General:master
from
elenagarrone:fep-2796-ar-icons
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauleustice
reviewed
Jan 14, 2025
pauleustice
reviewed
Jan 14, 2025
pauleustice
reviewed
Jan 14, 2025
pauleustice
reviewed
Jan 14, 2025
pauleustice
reviewed
Jan 14, 2025
pauleustice
reviewed
Jan 14, 2025
80d18e0
to
6b1de2b
Compare
AndreiRosu
reviewed
Jan 15, 2025
BREAKING CHANGE: Automatically loads the icon set, - there is no more need to call `registerIcon`. This function has been removed. - the getIcon function has been renamed `get` and it returns a Promise.
BREAKING CHANGE: Automatically loads the icon set, - there is no more need to call `registerBrandIcon`. This function has been removed. - the getBrandIcon function has been renamed `get` and it returns a Promise.
This is done because 'test' needs the icons to be available
6b1de2b
to
48986da
Compare
AndreiRosu
approved these changes
Jan 16, 2025
pauleustice
approved these changes
Jan 16, 2025
🎉 This PR is included in version 13.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains breaking changes:
.gitignore
package.json
halfToneColour
andoutlineColour
are always set.lintstagedrc.js
as how it worked was not ideal and the icons are now generated whennpm run build
runsregisterIcon
andregisterBrandIcon
from the registriesgetIcon
andgetBrandIcon
to be renamed toget
. They both return a Promise.pull_request.yml
to run the Build and Test job together. Build is needed before Test because it has to generate the icons sets.Note
All the changes have been tested within our apps and they work.
Additional test on deployed environment:
Checklist: