Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add a new config:'fileName' #174

Closed
wants to merge 4 commits into from

Conversation

fhyoga
Copy link

@fhyoga fhyoga commented Mar 1, 2019

No description provided.

@jdneo
Copy link
Member

jdneo commented Mar 7, 2019

@Dec-F Thank you for contribution. While, the PR contains too much formatting changes, which makes it difficult to review.

Another question is that will your request get satisfied if we implement the comment here: #119 (comment)

@jdneo

This comment has been minimized.

@fhyoga

This comment has been minimized.

@jdneo

This comment has been minimized.

@magic-akari
Copy link
Contributor

Hello. Any update here?

@jdneo
Copy link
Member

jdneo commented Aug 2, 2019

Sorry I do not update in time about this PR. The limitation for the file name is not valid anymore. Since the generated file will contains a comment to contain problem metadata, such as the problem id.

@jdneo
Copy link
Member

jdneo commented Sep 16, 2019

Hi @Dec-F,

Thank you for your contribution and great work! We now have a new setting: leetcode.filePath which I think can resolve this feature request.

I'm closing this PR but feel free to let me know if you have more ideas on this.

Thanks!

@jdneo jdneo closed this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants