Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs didn't say to include the tag in the form. #33

Closed
Teut2711 opened this issue Feb 2, 2021 · 6 comments
Closed

Docs didn't say to include the tag in the form. #33

Teut2711 opened this issue Feb 2, 2021 · 6 comments

Comments

@Teut2711
Copy link

Teut2711 commented Feb 2, 2021

I was looking at the docs but I thing it's missed to be told that {% include 'django_quill/media.html' %} is to be included. I wasted lot of time on this.

@cdesch
Copy link
Contributor

cdesch commented Feb 6, 2021

It says it here in the readme.md in 2. Form, but it could be added to docs form page

cdesch added a commit to cdesch/django-quill-editor that referenced this issue Feb 6, 2021
@cdesch
Copy link
Contributor

cdesch commented Feb 6, 2021

I added a fix for the docs in PR#34. @LeeHanYeong will need to update or republish the docs https://django-quill-editor.readthedocs.io/

@Teut2711
Copy link
Author

Teut2711 commented Feb 6, 2021

Also can you attach functionality for file upload? I know it doesn't exists in quill.js but more of less one can just insert additional handler and a font-awesome file upload icon.

@cdesch
Copy link
Contributor

cdesch commented Feb 6, 2021

Also can you attach functionality for file upload? I know it doesn't exists in quill.js but more of less one can just insert additional handler and a font-awesome file upload icon.

That is a little outside of my domain and not something quill supports. If you want to add it as a feature of this library in addition to quill, I encourage you to make a PR to add it.

@Teut2711
Copy link
Author

Teut2711 commented Feb 6, 2021

@cdesch ok , I will try as soon as I get some free time .

@Teut2711 Teut2711 changed the title Docs didn;t say to include the tag in the form. Docs didn't say to include the tag in the form. Feb 8, 2021
LeeHanYeong pushed a commit that referenced this issue Feb 9, 2021
* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [#33](#33)
@LeeHanYeong
Copy link
Owner

@cdesch @XtremeGood
Thank you for adding content to the document. This content has been updated to version 0.1.18.

LeeHanYeong pushed a commit that referenced this issue Feb 27, 2021
…son_string' (#41)

* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [#33](#33)

* adding None return for json_string
LeeHanYeong pushed a commit that referenced this issue Dec 8, 2021
* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [#33](#33)
LeeHanYeong pushed a commit that referenced this issue Dec 8, 2021
…son_string' (#41)

* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [#33](#33)

* adding None return for json_string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants