Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Click >= 7.0 to >= 8.0 #44

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[update] Click >= 7.0 to >= 8.0 #44

merged 1 commit into from
Sep 12, 2022

Conversation

lpascal-ledger
Copy link
Contributor

@lpascal-ledger lpascal-ledger commented Sep 5, 2022

For some reason, when installed through a dependency (like ragger -> ledgerwallet -> click), pip does not update click to a newer version, it stays at 7.0.
This triggers a conflict with other python packages such as speculos, which uses flask, which itself needs click>=8.0.

I'm baffled that pip can't update this package by itself (speculos does explicit the version of flask, and so does flask with click), but here I am, asking for a version bump, so that my CIs (ragger, app-exchange) won't fail on such lousy issue.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jibeee jibeee merged commit a915502 into master Sep 12, 2022
@jibeee jibeee deleted the deps/update branch September 12, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants