Fix defects found by CodeQL #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 71.15% 71.15%
=======================================
Files 5 5
Lines 260 260
=======================================
Hits 185 185
Misses 75 75 Continue to review full report at Codecov.
|
lpascal-ledger
force-pushed
the
codeql-fixes
branch
2 times, most recently
from
623c8a7
to
1d47e4a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lpascal-ledger
force-pushed
the
codeql-fixes
branch
from
1d47e4a
to
3f8c76e
Compare
lpascal-ledger
force-pushed
the
codeql-fixes
branch
from
3f8c76e
to
a7f821b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lpascal-ledger
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all the defects identified by CodeQL.
It doesn't add any feature. To fix #34 and #35, it was easier to remove support for hidraw (both hidapi and hidraw backends were supported for HID). This package was not updated for 12 years, there was actually no reason to keep compatibility with it.