Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback screen settings button icon rendering with the right color #7764

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: fallback screen settings button icon rendering with the right color #7764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-pandas-behave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"live-mobile": patch
---

Assign the right color to settings icon in Fallback camera permission screen
4 changes: 2 additions & 2 deletions apps/ledger-live-mobile/src/components/RequiresCameraPermissions/Fallback.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ type Props = {
hasNoBackground?: boolean;
};

const IconSettings = () => <Icon name="settings" size={16} color="neutral.c100" />;

const FallbackCameraBody: React.FC<Props> = ({
title,
description,
Expand All @@ -27,6 +25,8 @@ const FallbackCameraBody: React.FC<Props> = ({
}: Props) => {
const { colors } = useTheme();

const IconSettings = () => <Icon name="settings" size={16} color={colors.neutral.c00} />;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the prettier formatting, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep sure, i'm using the default prettier config in my VSCode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try using neutral.c100 please? :) Instead of using osTheme
if neutral.c100 not working try neutral.c00 I don't remember de right one
it will convert automatically according to the current theme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ! can you please send me (if exists) theming documentation or color palette docs/ref ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcayuelas-ledger done ✅

return (
<Flex flex={1} bg={hasNoBackground ? "transparent" : "background.main"} px={6}>
<Flex flex={1} alignItems="center" justifyContent="center">
Expand Down
Loading