Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): ledger sync navigation fixes #7753

Merged

Conversation

cgrellard-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

πŸ“ Description

Navigation fixes on sync success screen
Safeareaview added to the device step of the ledger sync flow

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner September 5, 2024 08:14
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:25am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:25am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:25am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:25am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:25am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 5, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the bugfix/ledger-sync-small-navigation-fixes branch from 68a4b09 to 168d767 Compare September 5, 2024 08:24
@mcayuelas-ledger mcayuelas-ledger merged commit d7163a7 into develop Sep 5, 2024
38 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/ledger-sync-small-navigation-fixes branch September 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants