Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LLM): pass some additional params to wallet-connect live-app when receiving a request [LIVE-13660] #7751

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Sep 5, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Tested manually on LLD and LLM (LLD already passes the arguments)
  • Impact of the changes:
    • Wallet Connect deeplink on LLM

📝 Description

Pass some additional params to wallet-connect live-app when receiving a request, allowing proper loading screen on the live-app

❓ Context

  • JIRA or GitHub link: LIVE-13660

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant requested a review from a team September 5, 2024 08:02
@Justkant Justkant self-assigned this Sep 5, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 5, 2024 8:03am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 5, 2024 8:03am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 5, 2024 8:03am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 5, 2024 8:03am
web-tools ⬜️ Ignored (Inspect) Sep 5, 2024 8:03am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 5, 2024
@Justkant Justkant merged commit e40d447 into develop Sep 5, 2024
38 of 39 checks passed
@Justkant Justkant deleted the feat/LIVE-13660 branch September 5, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants