Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [FIX]: Extra device action at the end of the remove member flow on LLM #7748

Merged

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Sep 4, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Don't run extra device action at the end of the remove member flow on LLM.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner September 4, 2024 13:48
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 4, 2024 1:48pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 4, 2024 1:48pm
native-ui-storybook ⬜️ Ignored (Inspect) Sep 4, 2024 1:48pm
react-ui-storybook ⬜️ Ignored (Inspect) Sep 4, 2024 1:48pm
web-tools ⬜️ Ignored (Inspect) Sep 4, 2024 1:48pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 4, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit f34dd22 into develop Sep 4, 2024
38 of 39 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the fix/llm-ledgersync-remove-member-extra-action branch September 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants