✨feat(lld): UI of inscriptions table for ordis #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
LucasWerey
force-pushed
the
feat/LIVE-12479_a
branch
2 times, most recently
from
39761c9
to
075494c
Compare
apps/ledger-live-desktop/src/newArch/features/Collectibles/types/Collection.ts
Show resolved
Hide resolved
...dger-live-desktop/src/newArch/features/Collectibles/components/Collection/TableRow/index.tsx
Outdated
Show resolved
Hide resolved
...live-desktop/src/newArch/features/Collectibles/components/Collection/TableRow/TokenTitle.tsx
Outdated
Show resolved
Hide resolved
.../src/newArch/features/Collectibles/Ordinals/components/Inscriptions/useInscriptionsModel.tsx
Outdated
Show resolved
Hide resolved
...er-live-desktop/src/newArch/features/Collectibles/Ordinals/components/Inscriptions/index.tsx
Outdated
Show resolved
Hide resolved
LucasWerey
force-pushed
the
feat/LIVE-12479_a
branch
3 times, most recently
from
7c61cfe
to
96b5f8f
Compare
LucasWerey
force-pushed
the
feat/LIVE-12479_a
branch
from
96b5f8f
to
f8c6953
Compare
Comment on lines
+28
to
+34
| const SatsIconContainer = styled(Flex)` | ||
| border-radius: 8px; | ||
| background: ${p => p.theme.colors.opacityDefault.c05}; | ||
| border: 1px solid ${p => p.theme.colors.opacityDefault.c10}; | ||
| padding: 8px; | ||
| `; | ||
|
|
There was a problem hiding this comment.
You maybe should put this outside of TableRow as it's specific to Stats ?
There was a problem hiding this comment.
Yes I've changed that in feat/LIVE-12479_b. There will be a dedicated component
mcayuelas-ledger
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This PR is the first of this ticket LIVE-12479. There will be other PRs to achieve this ticket.
Here there is the implementation of a dummy table (only UI) with hardcoded data. It's hidden under a ff so not visible. Integration test will be added on another PR
Screen.Recording.2024-09-04.at.15.02.03.mov
❓ Context
🧐 Checklist for the PR Reviewers