-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bnb custom fee staying as type2 after prepare #7741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Skipped Deployments
|
hedi-edelbloute
previously approved these changes
Sep 4, 2024
CremaFR
force-pushed
the
fix/LIVE-13900
branch
from
September 4, 2024 14:19
b91456d
to
331a638
Compare
cpellizzari-ledger
previously approved these changes
Sep 4, 2024
libs/coin-modules/coin-evm/src/__tests__/unit/prepareTransaction.unit.test.ts
Outdated
Show resolved
Hide resolved
lambertkevin
previously approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rework π
kallen-ledger
previously approved these changes
Sep 6, 2024
CremaFR
dismissed stale reviews from kallen-ledger and lambertkevin
via
September 6, 2024 09:17
f218e31
liviuciulinaru
approved these changes
Sep 6, 2024
lambertkevin
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
Better evm type 2 to 0 conversion. Function assumed that if type2 field are undefined it is a type 0 but in our use case, transaction is created with the bridge.createTransaction which set the field to 0 and make the check fails.
β Context
- JIRA or GitHub link:
π§ Checklist for the PR Reviewers