Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛹 [FIX]: Handle Ledgersync onboarding errors #7733

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Sep 3, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: Onboarding flow via Ledgersync:
    • The on boarded ledger live scans QR code of a ledger live with no Trustchain.
    • The on boarded ledger live's QR code gets scanned by a device with no Trustchain.
    • The on boarded ledger live connects to a device with no Trustchain.

📝 Description

With device With QR code
Simulator Screenshot - iPhone SE (3rd generation) - 2024-09-03 at 16 33 06 simulator_screenshot_C8879AB0-1505-4CBC-84A5-03E7D5F48E66

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner September 3, 2024 13:26
@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 3, 2024
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 3:26pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 3:26pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 3:26pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 3:26pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 3:26pm

@thesan thesan changed the title 🛹 [Fix]: Ledgersync onboarding errors 🛹 [FIX]: Ledgersync onboarding errors Sep 3, 2024
@thesan thesan changed the title 🛹 [FIX]: Ledgersync onboarding errors 🛹 [FIX]: Handle Ledgersync onboarding errors Sep 3, 2024
@thesan thesan merged commit ef99222 into develop Sep 4, 2024
55 of 57 checks passed
@thesan thesan deleted the fix/onboarding-errors branch September 4, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants