-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/llm ledger sync redirection on sync again #7729
Feat/llm ledger sync redirection on sync again #7729
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Skipped Deployments
|
27bb455
to
8ce087f
Compare
8ce087f
to
84dcd64
Compare
apps/ledger-live-mobile/src/newArch/features/WalletSync/hooks/useSyncWithQrCode.ts
Outdated
Show resolved
Hide resolved
1e91120
to
c5d7221
Compare
apps/ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/index.tsx
Outdated
Show resolved
Hide resolved
...edger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/useAddAccountViewModel.ts
Outdated
Show resolved
Hide resolved
.../ledger-live-mobile/src/newArch/features/WalletSync/screens/Activation/ActivationSuccess.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/Settings/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
|
||
const closeDrawer = useCallback(() => { | ||
dispatch(setLedgerSyncActivateDrawer(false)); | ||
}, [dispatch]); | ||
setCurrentStep(Steps.Activation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the only file that we need to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's the only place where we set it to false
c5d7221
to
b7aca24
Compare
β Checklist
npx changeset
was attached.π Description
Ledger sync redirects on qr code when trying to sync again after a successful sync
Instead of passing the
currentStep
and thesetCurrentStep
of the activation drawer to every components, we store it with redux and use an action to handle to state of the current step. This gives us more control over it and it allows us to set the step from anywhereβ Context
π§ Checklist for the PR Reviewers