Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Remove Trustchain from error and handle it in generic way #7725

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 2, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Remove Trustchain from error and handle it in generic way

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 1:31pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 1:31pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 1:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 1:31pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 1:31pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Sep 2, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit b2c4c51 into develop Sep 3, 2024
48 of 52 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/error-trustchaininLL branch September 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants