Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Minors bugs on LedgerSync #7717

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[FIX]: Minors bugs on LedgerSync #7717

merged 2 commits into from
Sep 2, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 30, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix some minors UX bugs

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 30, 2024 09:54
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 9:41am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:41am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:41am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 30, 2024
@mcayuelas-ledger mcayuelas-ledger force-pushed the bugfix/quick-fix-ledgerSync branch 4 times, most recently from 566427d to db9d053 Compare August 30, 2024 15:31
thesan
thesan previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcayuelas-ledger mcayuelas-ledger force-pushed the bugfix/quick-fix-ledgerSync branch 2 times, most recently from 4ad4073 to fdeeae1 Compare September 2, 2024 09:06
@mcayuelas-ledger mcayuelas-ledger merged commit 9a4a3bc into develop Sep 2, 2024
56 of 57 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/quick-fix-ledgerSync branch September 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@thesan thesan Awaiting requested review from thesan

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcayuelas-ledger @thesan @cgrellard-ledger