Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm/lld): ledger sync - improve account names module #7714

Merged

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Aug 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

πŸ“ Description

Improve account names module to avoid erasing a custom name with a default one when two instances are pushing at the same time

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner August 29, 2024 16:33
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 2, 2024 8:12am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 8:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 8:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 8:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 8:12am

@cgrellard-ledger cgrellard-ledger force-pushed the feat/ledger-sync-improve-account-names-module branch from 9a97d46 to 0d64e83 Compare September 2, 2024 08:05
@cgrellard-ledger cgrellard-ledger merged commit 5ecbe88 into develop Sep 2, 2024
57 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/ledger-sync-improve-account-names-module branch September 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants