Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›£οΈ [FEAT]: Create the /ledgersync deeplink #7706

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Aug 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Link ledgerlive://ledgersync to the ledger sync page.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner August 29, 2024 07:49
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:57am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 9:57am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 29, 2024
@thesan thesan marked this pull request as draft August 29, 2024 08:17
@thesan thesan force-pushed the feature/ledgersync-deeplink branch from c188e6a to e7e8549 Compare August 29, 2024 09:56
@thesan thesan marked this pull request as ready for review August 30, 2024 07:53
@mcayuelas-ledger
Copy link
Contributor

@cgrellard-ledger you can use setLedgerSyncActivateDrawer now ;)

@thesan thesan merged commit 84ea362 into develop Aug 30, 2024
49 of 51 checks passed
@thesan thesan deleted the feature/ledgersync-deeplink branch August 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants