Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/wallet sync loading screen on initialization #7691

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Feat/wallet sync loading screen on initialization #7691

merged 1 commit into from
Aug 29, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Aug 27, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Added a loading screen after initializing ledger sync while accounts are synchronizing locally

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Aug 29, 2024 8:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 8:07am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 8:07am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 8:07am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 8:07am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Aug 27, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-loading-screen-on-initialization branch from 66ededc to 8a02db7 Compare August 27, 2024 16:05
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review August 27, 2024 16:10
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner August 27, 2024 16:10
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-loading-screen-on-initialization branch from 8a02db7 to d9b8256 Compare August 28, 2024 16:27
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-loading-screen-on-initialization branch from d9b8256 to fe42851 Compare August 28, 2024 16:37
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-loading-screen-on-initialization branch from fe42851 to 458adc3 Compare August 29, 2024 08:06
@cgrellard-ledger cgrellard-ledger merged commit ce18c9b into develop Aug 29, 2024
56 of 57 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/wallet-sync-loading-screen-on-initialization branch August 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrellard-ledger @mcayuelas-ledger