🐦🔥 [FIX]: Refresh ledger sync QR code on expiration #7690
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
desktop
thesan
changed the title
thesan
force-pushed
the
fix/refresh-trustchain-qr-code
branch
from
927ebdb
to
ae6dd17
Compare
|
At the end we have an error message? |
@mcayuelas-ledger the error message won't show even if you stayed several days on the QR code page. Every time the QR code expire a new WS connection will created and the QR code will be refreshed. But if the WS connection closes in less than 30 seconds something else is wrong so the "WS closed prematurely" error would be shown. I wanted to avoid to constantly refresh the WS connection when something actually is wrong with it (and also potentially IP ban users). (In the screen recording I lowered the 30 seconds to 3). |
thesan
force-pushed
the
fix/refresh-trustchain-qr-code
branch
from
ae6dd17
to
4d375a7
Compare
| } | ||
| if (e instanceof NoTrustchainInitialized) { | ||
| dispatch(setFlow({ flow: Flow.Synchronize, step: Step.UnbackedError })); | ||
| } |
There was a problem hiding this comment.
we need to add
setError(e); throw e; also no? Like before
There was a problem hiding this comment.
The setError is not needed because react-query manages the error (that's why I removed the useState).
For the throw I don't think it's needed either. From my understanding it was here to avoid the then that follows. Or am I missing something ?
| if (e instanceof NoTrustchainInitialized) { | ||
| setCurrentStep(Steps.UnbackedError); | ||
| } | ||
| }, |
✅ Checklist
npx changesetwas attached.📝 Description
It retries the QR code processing flow when the WS closes unexpectedly. Since AFAIK there is no way to make sure the WS closed because of the QR code expiration: if the connection closes in less than 30 seconds the flow is not retried and the old error is shown. Here's a demo the behaviour with a min time 3 seconds:
Screen.Recording.2024-08-27.at.17.12.23.mov
I ended up using react query because I was getting some weird behaviour with the old logic. However I didn't manage to use the build in
retryoption because thedelayoption didn't work for me it kept on retrying after +30 seconds instead of immediatley 🤷.❓ Context
🧐 Checklist for the PR Reviewers