Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Update ManageKey flow copy #7689

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[FEAT]: Update ManageKey flow copy #7689

merged 1 commit into from
Aug 28, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 27, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update ManageKey flow copy

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 27, 2024 14:37
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:49pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:49pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Aug 27, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 302dcd7 into develop Aug 28, 2024
36 of 38 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/llm-manage-key-copy branch August 28, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcayuelas-ledger @cgrellard-ledger