Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ [SUPPORT] : Revamp LedgerSyncDebugger #7677

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 26, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Revamp LedgerSync Debugger
  • Introduce v0 of LedgerSyncInfo checker
Screen.Recording.2024-08-26.at.16.00.18.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 26, 2024 14:04
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 26, 2024 2:04pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 26, 2024 2:04pm
native-ui-storybook ⬜️ Ignored (Inspect) Aug 26, 2024 2:04pm
react-ui-storybook ⬜️ Ignored (Inspect) Aug 26, 2024 2:04pm
web-tools ⬜️ Ignored (Inspect) Aug 26, 2024 2:04pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Aug 26, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 3de9eb6 into develop Aug 26, 2024
33 of 39 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the support/ledger-sync-debug branch August 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants