Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(live-13764): show gasPrice as error instead of warning #7669

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Aug 26, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

show gasPrice as error instead of warning

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner August 26, 2024 04:05
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 26, 2024 4:05am
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 26, 2024 4:05am
native-ui-storybook ⬜️ Ignored (Inspect) Aug 26, 2024 4:05am
react-ui-storybook ⬜️ Ignored (Inspect) Aug 26, 2024 4:05am
web-tools ⬜️ Ignored (Inspect) Aug 26, 2024 4:05am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Aug 26, 2024
@liviuciulinaru liviuciulinaru merged commit 6ccd01c into develop Aug 26, 2024
59 of 61 checks passed
@liviuciulinaru liviuciulinaru deleted the fix/live-13764/d1-gasPrice-as-error branch August 26, 2024 12:58
bharamboure-ledger pushed a commit that referenced this pull request Sep 2, 2024
* fix: show gasPrice as error not warning

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants