Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—οΈ [FIX]: llm "Delete my encryption key" action on wrong seed errors #7668

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Aug 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The "Delete my encryption key" on the wrong seed error was not doing anything on the add member flow and just lead to the main wallet sync page on the remove member flow.

It now shows the delete key confirmation drawer:

Screen.Recording.2024-08-23.at.18.54.16.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner August 23, 2024 17:04
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 5:07pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 5:07pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 5:07pm
react-ui-storybook ⬜️ Ignored (Inspect) Aug 23, 2024 5:07pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 5:07pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 23, 2024
@thesan thesan merged commit 120c1f8 into develop Aug 26, 2024
36 of 37 checks passed
@thesan thesan deleted the fix/llm-trustchain-switch-device branch August 26, 2024 13:23
bharamboure-ledger pushed a commit that referenced this pull request Sep 2, 2024
…7668)

* Fix the "Delete my encription key" action on sync error

* Update changelog

---------

Co-authored-by: Theophile Sandoz <Theophile Sandoz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants