-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup analytics for Web3Hub #7666
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should try to use TrackScreen
instead of manually adding track
calls on every interaction
Using TrackScreen
with the arguments like category or manifestId gives us the full user journey through the app already and we can reduce the number of events and track
calls that we need to add in the code, also TrackScreen
is used every where
It might still be good to keep some of the track
calls for some interactions if we really want to track this but in general we should be able to do most of it with the TrackScreen
as we did in the screens/Platform/v2
onFocus={() => { | ||
track("web3hub_search_focus", { | ||
component: `SearchInput`, | ||
}); | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure tracking this is really needed
track("web3hub_disclaimer_closed", { | ||
component: `Disclaimer`, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might send too much informations because close is usually called multiple times but also bad informations because close is called regardless of it being close onConfirm or when really closing
track("web3hub_disclaimer_toggle", { | ||
component: `Disclaimer`, | ||
action: `turn checkbox to ${isChecked ? "off" : "on"}`, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we actually need to know this, even more as we don't even look if we succeed going to the app
Using the TrackScreen
should be enough for us to know if the user is able to navigate to different screens
track("web3hub_section_clicked", { | ||
page: "Home", | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again not sure we want to track this as we can just track the screen instead, we never did track this kind of click for other screens and it doesn't tell you if you end up in the actual screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having TrackScreen on the main page would be called every time he switch from search to main or quiting an app ? If we just wanna track how many timesa user clicl on the Discover then might be better to implement this here
.changeset/pink-walls-tickle.md
Outdated
"live-mobile": patch | ||
--- | ||
|
||
Analytics improved on Web3Hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably more correct
Analytics improved on Web3Hub | |
Setup analytics on Web3Hub |
track("web3hub_category_clicked", { | ||
component: `CategoriesList`, | ||
category: item.id, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this one too as we should be able to track the category selected with a TrackScreen
and the proper props
It would give us the guarantee that we actually updated the state when the user clicks instead of just tracking a click
track("web3hub_app_clicked", { | ||
component: `ManifestsList`, | ||
page: "Web3HubMain", | ||
app: manifestId, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I said on the other track events that could be replaced by a simple TrackScreen
could also be applied for this as it would gives us the full flow from each screen with minimal events on the dashboard
cd99068
to
034612d
Compare
β Checklist
npx changeset
was attached.π Description
Setup analytics for Web3Hub
β Context
π§ Checklist for the PR Reviewers