Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup analytics for Web3Hub #7666

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

RamyEB
Copy link
Contributor

@RamyEB RamyEB commented Aug 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Setup analytics for Web3Hub

  • App clicked from main page
  • App clicked from horizontal list
  • App clicked from search page
  • Input focus from main page
  • categories clicked
  • disclaimer toggle

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@RamyEB RamyEB requested a review from a team as a code owner August 23, 2024 16:46
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:23am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:23am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:23am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:23am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 9:23am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Aug 23, 2024
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try to use TrackScreen instead of manually adding track calls on every interaction
Using TrackScreen with the arguments like category or manifestId gives us the full user journey through the app already and we can reduce the number of events and track calls that we need to add in the code, also TrackScreen is used every where

It might still be good to keep some of the track calls for some interactions if we really want to track this but in general we should be able to do most of it with the TrackScreen as we did in the screens/Platform/v2

Comment on lines 58 to 62
onFocus={() => {
track("web3hub_search_focus", {
component: `SearchInput`,
});
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure tracking this is really needed

Comment on lines 79 to 81
track("web3hub_disclaimer_closed", {
component: `Disclaimer`,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might send too much informations because close is usually called multiple times but also bad informations because close is called regardless of it being close onConfirm or when really closing

Comment on lines 55 to 58
track("web3hub_disclaimer_toggle", {
component: `Disclaimer`,
action: `turn checkbox to ${isChecked ? "off" : "on"}`,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we actually need to know this, even more as we don't even look if we succeed going to the app
Using the TrackScreen should be enough for us to know if the user is able to navigate to different screens

Comment on lines 151 to 153
track("web3hub_section_clicked", {
page: "Home",
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again not sure we want to track this as we can just track the screen instead, we never did track this kind of click for other screens and it doesn't tell you if you end up in the actual screen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having TrackScreen on the main page would be called every time he switch from search to main or quiting an app ? If we just wanna track how many timesa user clicl on the Discover then might be better to implement this here

"live-mobile": patch
---

Analytics improved on Web3Hub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more correct

Suggested change
Analytics improved on Web3Hub
Setup analytics on Web3Hub

Comment on lines 26 to 29
track("web3hub_category_clicked", {
component: `CategoriesList`,
category: item.id,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one too as we should be able to track the category selected with a TrackScreen and the proper props
It would give us the guarantee that we actually updated the state when the user clicks instead of just tracking a click

Comment on lines 58 to 62
track("web3hub_app_clicked", {
component: `ManifestsList`,
page: "Web3HubMain",
app: manifestId,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I said on the other track events that could be replaced by a simple TrackScreen could also be applied for this as it would gives us the full flow from each screen with minimal events on the dashboard

Justkant
Justkant previously approved these changes Sep 2, 2024
@RamyEB RamyEB merged commit 32b33b6 into develop Sep 3, 2024
38 checks passed
@RamyEB RamyEB deleted the feat/LIVE-12752-setup-analytics branch September 3, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants