Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]: Add fromLedgerSyncOnboarding to trigger right onClose action for Activation #7661

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 23, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

fromLedgerSyncOnboarding added in Store to differentiate where we come from to close correctly and redirect to the right screen

Screen_Recording_20240823_121307_LL.DEV.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 23, 2024 10:16
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 23, 2024 10:16am
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 23, 2024 10:16am
native-ui-storybook ⬜️ Ignored (Inspect) Aug 23, 2024 10:16am
react-ui-storybook ⬜️ Ignored (Inspect) Aug 23, 2024 10:16am
web-tools ⬜️ Ignored (Inspect) Aug 23, 2024 10:16am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 23, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit b07279f into develop Aug 23, 2024
37 of 40 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/close-activation-ws branch August 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants