Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“ [FIX]:Minor copy updates for LedgerSync (LLM) #7655

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Minor copy updates for LedgerSync (LLM)

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 22, 2024 14:09
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:43pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:43pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Aug 22, 2024
thesan
thesan previously approved these changes Aug 22, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit c358bb7 into develop Aug 23, 2024
46 of 48 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/copy-ws-llm branch August 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants