fix: return transaction.feesStrategy gasOption instead of the medium value #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
CremaFR
changed the title
bharamboure-ledger
pushed a commit
that referenced
this pull request
Sep 2, 2024
…value (#7652) * fix: return transaction.feesStrategy instead of medium * chore: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
When not providing gasOption, prepare Transactions makes a node api call to fetch medium fees regardless of what is asked on feeStrategy. This PR aims to fix this by returning the option asked on the transaction before defaulting to medium
❓ Context
- JIRA or GitHub link:
🧐 Checklist for the PR Reviewers