Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎭 Add more descriptive mobile device name to the trustchain #7651

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Aug 22, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Display the mobile phone models or even user defined name (if available) instead of the OS versions. To achieve this this PR introduces react-native-device-info as a dependency.

Before After
Simulator Screenshot - iPhone SE (3rd generation) - 2024-08-22 at 12 27 12 Simulator Screenshot - iPhone SE (3rd generation) - 2024-08-22 at 12 41 42

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner August 22, 2024 10:44
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:15pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:15pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 2:15pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 22, 2024
Copy link

socket-security bot commented Aug 22, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 699 kB schie

View full report↗︎

@thesan thesan merged commit 6f781da into develop Aug 23, 2024
56 of 58 checks passed
@thesan thesan deleted the feature/trustchain-mobile-device-name branch August 23, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants