Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wallet sync synchronize via qr code from mobile to desktop #7646

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Aug 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • [] Covered by automatic tests.
  • Impact of the changes:

πŸ“ Description

Added the synchronization of a trustchain from mobile to desktop by scanning the QR code

This hasn't been tested manually yet
Integration tests to be added once the backend supports those changes

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools πŸ›‘ Canceled (Inspect) Aug 23, 2024 4:39pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 4:39pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 4:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 4:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 4:39pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 22, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from 6c810b7 to 290e495 Compare August 22, 2024 10:03
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from 290e495 to 819d0e6 Compare August 22, 2024 13:48
@live-github-bot live-github-bot bot added the translations Translation files have been touched label Aug 22, 2024
@cgrellard-ledger cgrellard-ledger changed the base branch from develop to feat/unbacked-error-ws August 22, 2024 13:48
@live-github-bot live-github-bot bot removed the translations Translation files have been touched label Aug 22, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from f4d732e to 2dd87f5 Compare August 22, 2024 17:03
@live-github-bot live-github-bot bot added the translations Translation files have been touched label Aug 23, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from 08291de to fecacf5 Compare August 23, 2024 12:11
@cgrellard-ledger cgrellard-ledger changed the base branch from feat/unbacked-error-ws to develop August 23, 2024 12:34
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from 12dc32f to 97ba3eb Compare August 23, 2024 13:38
@cgrellard-ledger cgrellard-ledger force-pushed the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch from 97ba3eb to 7991904 Compare August 23, 2024 13:54
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review August 23, 2024 13:54
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner August 23, 2024 13:54
@cgrellard-ledger cgrellard-ledger merged commit 267526c into develop Aug 26, 2024
56 of 69 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/wallet-sync-synchronize-via-qr-code-from-mobile-to-desktop branch August 26, 2024 09:19
bharamboure-ledger pushed a commit that referenced this pull request Sep 2, 2024
* Unbacked Screen

* feat: wallet sync synchronize via qr code from mobile to desktop

---------

Co-authored-by: Martin Cayuelas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants