Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-13753 use mainaccount unit to display fees if no fees options #7644

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Aug 21, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The gas fees unit displayed was that of the token account and not of the main account.

BEFORE / AFTER:

image image

On LLD there is no issue (anymore, as it was fixed recently in https://ledgerhq.atlassian.net/jira/software/c/projects/LIVE/boards/465?selectedIssue=LIVE-13362):
image

image

❓ Context

  • JIRA or GitHub link: LIVE-13753

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 2:01pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 2:01pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 2:01pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 2:01pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 2:01pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 21, 2024
@Wozacosta Wozacosta marked this pull request as ready for review August 21, 2024 22:33
@Wozacosta Wozacosta requested a review from a team as a code owner August 21, 2024 22:33
lambertkevin
lambertkevin previously approved these changes Aug 22, 2024
@Wozacosta Wozacosta force-pushed the fix/send-flow-token-account-fees-unit branch 2 times, most recently from 1f50aac to 8dfe972 Compare August 22, 2024 16:24
@Wozacosta Wozacosta requested a review from a team as a code owner August 22, 2024 17:45
@Wozacosta Wozacosta force-pushed the fix/send-flow-token-account-fees-unit branch from 1f76f6f to 314c21a Compare August 23, 2024 14:00
@Wozacosta Wozacosta merged commit 6cb49b8 into develop Aug 23, 2024
37 checks passed
@Wozacosta Wozacosta deleted the fix/send-flow-token-account-fees-unit branch August 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants