Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🀲 [FEAT] Create accounts with the receive market quick action #7635

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Aug 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The receive market quick action will redirect to the account creation step of the receive flows when no account is available for the given currency.

Before After
Simulator Screenshot - iPhone SE (3rd generation) - 2024-08-20 at 16 43 32 Simulator Screenshot - iPhone SE (3rd generation) - 2024-08-20 at 16 42 51

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 3:40pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 3:40pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 3:40pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 3:40pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 3:40pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 20, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Aug 20, 2024

Mobile Bundle Checks

Comparing 3c644ca against f839708.

βœ… Previous issues have all been fixed.

@thesan thesan force-pushed the feature/currency-quick-actions branch from 235ea33 to 5550d3d Compare August 22, 2024 13:23
@thesan thesan force-pushed the feature/receive-market-quick-action branch from c39f7dc to c119e9d Compare August 22, 2024 13:33
Base automatically changed from feature/currency-quick-actions to develop August 22, 2024 15:34
@thesan thesan dismissed mcayuelas-ledger’s stale review August 22, 2024 15:34

The base branch was changed.

@thesan thesan changed the title 🀲 Create accounts with the receive market quick action 🀲 [FEAT] Create accounts with the receive market quick action Aug 22, 2024
@thesan thesan force-pushed the feature/receive-market-quick-action branch from c119e9d to 3c644ca Compare August 22, 2024 15:39
@thesan thesan marked this pull request as ready for review August 22, 2024 15:40
@thesan thesan requested a review from a team as a code owner August 22, 2024 15:40
@thesan thesan merged commit e85f65b into develop Aug 23, 2024
36 of 39 checks passed
@thesan thesan deleted the feature/receive-market-quick-action branch August 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants