-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dependencies support on wallet-api and dapp browser for transaction #7634
Conversation
…nsaction Also bump the wallet-api to add dependencies option
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected] |
apps/ledger-live-desktop/src/renderer/modals/SignTransaction/steps/StepConnectDevice.tsx
Outdated
Show resolved
Hide resolved
@@ -11,7 +11,7 @@ type Props = { | |||
choices: string[]; | |||
multipleChoices: boolean; | |||
path: string; | |||
initalValue: string[] | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
✅ Checklist
npx changeset
was attached.📝 Description
Add dependencies support on wallet-api and dapp browser for transaction by exposing the dependencies param already present in the connectApp action
Also bump the wallet-api to add dependencies option
Tested manually with current prod and this PR especially with the changes on the dapp-browser v2 where I made sure we don't introduce a breaking change for old versions of LL if we use the option.
You can use this manifest below to test that we install the listed apps when doing the transaction
❓ Context
🧐 Checklist for the PR Reviewers