Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger Sync - Fixed the getOrCreateTrustchain when another instance deleted the trustchain #7632

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Aug 20, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Fixed the getOrCreateTrustchain when another instance deleted the trustchain
It was due to Ledger Live using the previous token to create a new trustchain

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner August 20, 2024 13:04
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:11pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:11pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:11pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 20, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the bugfix/ledger-sync-no-such-trustchain-error-on-destroy branch from 382abe8 to 1befcd4 Compare August 20, 2024 13:04
@cgrellard-ledger cgrellard-ledger merged commit 271f90d into develop Aug 21, 2024
56 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/ledger-sync-no-such-trustchain-error-on-destroy branch August 21, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants