Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add translation for back to quote CTA in WebPTXPlayer #7629

Merged

Conversation

mwiercinska
Copy link
Contributor

@mwiercinska mwiercinska commented Aug 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replacing a hardcoded value for "Quote" with new common translations in LLM and LLD, in WebPTXPlayer.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 5:04pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 5:04pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 5:04pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 5:04pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 5:04pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Aug 20, 2024
@mwiercinska mwiercinska changed the title Chore/live 9270 buy fe llm lld missing translation chore: add translation for back to quote CTA in WebPTXPlayer Aug 20, 2024
@mwiercinska mwiercinska force-pushed the chore/LIVE-9270-buy-fe-llm-lld-missing-translation branch from fea9e58 to e6d0eed Compare August 20, 2024 17:03
@mwiercinska mwiercinska marked this pull request as ready for review August 21, 2024 09:37
@mwiercinska mwiercinska requested a review from a team as a code owner August 21, 2024 09:37
@chrisduma-ledger
Copy link
Contributor

LGTM! Great work!

@mwiercinska mwiercinska merged commit 81468af into develop Aug 21, 2024
64 of 70 checks passed
@mwiercinska mwiercinska deleted the chore/LIVE-9270-buy-fe-llm-lld-missing-translation branch August 21, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants