Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden header should show again when searching [LIVE-13727] #7626

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Aug 20, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Animation are not tested automatically, I tested it manually
  • Impact of the changes:
    • Web3Hub still behind a disabled FF

📝 Description

Hidden header should show again when searching
On the search page the header can be hidden while keeping the focus on the search bar, if you add or remove a character while the header is hidden it won’t show again when the list reset to the top

Before After
before-fix.mov
after-fix.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Aug 20, 2024
@Justkant Justkant requested a review from a team as a code owner August 20, 2024 07:48
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 20, 2024 7:48am
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 20, 2024 7:48am
native-ui-storybook ⬜️ Ignored (Inspect) Aug 20, 2024 7:48am
react-ui-storybook ⬜️ Ignored (Inspect) Aug 20, 2024 7:48am
web-tools ⬜️ Ignored (Inspect) Aug 20, 2024 7:48am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 20, 2024
@Justkant Justkant merged commit 17ca82c into develop Aug 20, 2024
38 of 40 checks passed
@Justkant Justkant deleted the bugfix/LIVE-13727 branch August 20, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants