Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing query params for web3hub manifests requests [LIVE-13726] #7624

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Aug 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Tested manually as we use mocks on our tests
  • Impact of the changes:
    • Web3hub but still behind a disabled FF

πŸ“ Description

Add missing query params for web3hub manifests requests
Also matches the current prod version for Android and iOS build in dev to get the proper manifest back from the API

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Also matches the current prod version for android and ios build in dev to get the proper manifest back from the API
@Justkant Justkant self-assigned this Aug 20, 2024
@Justkant Justkant requested review from a team as code owners August 20, 2024 07:19
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:17am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:17am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:17am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:17am
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 8:17am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 20, 2024
ComradeAERGO
ComradeAERGO previously approved these changes Aug 20, 2024
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justkant Justkant merged commit 4161188 into develop Aug 20, 2024
36 of 37 checks passed
@Justkant Justkant deleted the bugfix/web3hub-request branch August 20, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants