-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add locale and ticker query params for buy/sell #7610
feat: add locale and ticker query params for buy/sell #7610
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Skipped Deployments
|
8e56e2f
to
4e110cb
Compare
This reverts commit 5c755b9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can our buy-sell app support this change without any change?
@sarneijim Neither of the new query params is expected or explicitly used in buy-sell-ui at the moment and as far as I can tell they are coming through as expected and not causing any issues locally but you'll know better if this could have any side effects that are not obvious. And as agreed, we will use these to format numbers based on locale but that will be done under a separate ticket. |
β Checklist
npx changeset
was attached.π Description
Adding the locale and currencyTicker of ledger-live app as a query parameter to the buy-sell-ui live app.
β Context
π§ Checklist for the PR Reviewers