Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add locale and ticker query params for buy/sell #7610

Merged

Conversation

mwiercinska
Copy link
Contributor

@mwiercinska mwiercinska commented Aug 15, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Adding the locale and currencyTicker of ledger-live app as a query parameter to the buy-sell-ui live app.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:09pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:09pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:09pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 15, 2024
@mwiercinska mwiercinska force-pushed the feat/LIVE-8912-add-region-locale-and-currency-ticker branch from 8e56e2f to 4e110cb Compare August 16, 2024 10:14
@mwiercinska mwiercinska marked this pull request as ready for review August 16, 2024 14:20
@mwiercinska mwiercinska requested review from a team as code owners August 16, 2024 14:20
Copy link
Contributor

@sarneijim sarneijim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can our buy-sell app support this change without any change?

@mwiercinska
Copy link
Contributor Author

Can our buy-sell app support this change without any change?

@sarneijim Neither of the new query params is expected or explicitly used in buy-sell-ui at the moment and as far as I can tell they are coming through as expected and not causing any issues locally but you'll know better if this could have any side effects that are not obvious.

And as agreed, we will use these to format numbers based on locale but that will be done under a separate ticket.

@mwiercinska mwiercinska merged commit 65a3622 into develop Aug 19, 2024
48 of 52 checks passed
@mwiercinska mwiercinska deleted the feat/LIVE-8912-add-region-locale-and-currency-ticker branch August 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants