Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in exchange-app #7608

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: typo in exchange-app #7608

merged 1 commit into from
Aug 15, 2024

Conversation

chrisduma-ledger
Copy link
Contributor

@chrisduma-ledger chrisduma-ledger commented Aug 15, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fixes typo

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@chrisduma-ledger chrisduma-ledger requested a review from a team as a code owner August 15, 2024 10:22
@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:26am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 15, 2024 10:26am
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 15, 2024 10:26am
native-ui-storybook ⬜️ Ignored (Inspect) Aug 15, 2024 10:26am
react-ui-storybook ⬜️ Ignored (Inspect) Aug 15, 2024 10:26am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Aug 15, 2024
@chrisduma-ledger chrisduma-ledger merged commit a3fbf6d into develop Aug 15, 2024
32 of 34 checks passed
@chrisduma-ledger chrisduma-ledger deleted the hotfix/typo-app-exchange branch August 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarneijim sarneijim sarneijim approved these changes

Assignees

@chrisduma-ledger chrisduma-ledger

Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisduma-ledger @sarneijim