Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”’ [FIX] Trustchain switch device while logged in case #7603

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Aug 14, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Show the right error when just after caching the device JWT the device is switched.

Before After
Screenshot 2024-08-14 at 11 25 56 Screenshot 2024-08-14 at 11 28 51

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner August 14, 2024 09:39
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:41am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:41am
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:41am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Aug 14, 2024
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thesan thesan merged commit 5c738cb into develop Aug 19, 2024
55 of 56 checks passed
@thesan thesan deleted the fix/switch-device-jwt branch August 19, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants