-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨feat(llm/lld): avoid watchloop when ff is off #7601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
thesan
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ypolishchuk-ledger
previously approved these changes
Aug 14, 2024
LucasWerey
force-pushed
the
feat/LIVE-13546-c
branch
2 times, most recently
from
August 16, 2024 11:55
67c6213
to
105774c
Compare
LucasWerey
force-pushed
the
feat/LIVE-13546-c
branch
from
August 16, 2024 13:31
105774c
to
397176d
Compare
LucasWerey
force-pushed
the
feat/LIVE-13546-c
branch
from
August 16, 2024 15:15
7355506
to
6d59a67
Compare
cgrellard-ledger
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
We don't want to run the LS watchloop when the ff is disabled on LLM and LLD
Note
Jest config has been updated also to be able to run
pnpm desktop test:jest _fileName_
and to exclude all shared files from test on LLD as it's done on LLMAdd a custom resolver for the firebase feature flag also for Jest so we can access them during tests
Add fireBase provider to renderHook of test utils
Move helpers from testHelper to shared
RecipientField tests have been updated with a mocked FirebaseFeatureFlagsProvider so tests don't failed
Add renderHook to test-renderer to be able to test hooks
Mock LS for tests
Warning
WIP
setOnUserRefresh(() => onUserRefreshIntent);
I suppose that it's caused by the fact we use some timeout or by the fact we called a
set
inside the useEffectA possibility would be to use
useRef instead of useState for setOnUserRefresh
this way the test doesn't loop. I've pushed this solution under this commit. It looks like the behaviour remains the same.❓ Context
🧐 Checklist for the PR Reviewers