Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CN-476): add category param filter to llm platform discover section #7580

Merged
merged 3 commits into from
Aug 14, 2024
Merged

feat(CN-476): add category param filter to llm platform discover section #7580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7e14a8
feat/mobile: enable deep link to discover by category
marcotoniut-ledger Aug 12, 2024
6417959
chore: changelog
marcotoniut-ledger Aug 12, 2024
e0c13b4
Merge branch 'develop' into CN-476-add-category-param-filter-to-llm-p…
marcotoniut-ledger Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/soft-kings-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"live-mobile": minor
"@ledgerhq/live-common": minor
---

Add discover section deep link initial category filter to enable links like `ledgerlive://discover?category=restaking` to load the discover screen with the category pre-selected
11 changes: 10 additions & 1 deletion apps/ledger-live-mobile/src/screens/Platform/v2/Catalog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,22 @@ import { RecentlyUsed } from "./RecentlyUsed";
import { CatalogSection } from "./CatalogSection";
import { DAppDisclaimer } from "./DAppDisclaimer";
import { LocalLiveApp } from "./LocalLiveApp";
import { useRoute } from "@react-navigation/native";

const AnimatedView = Animatable.View;

export function Catalog() {
const { t } = useTranslation();
const title = t("browseWeb3.catalog.title");
const { categories, recentlyUsed, search, disclaimer, localLiveApps } = useCatalog();

const { params } = useRoute();

const deeplinkInitialCategory =
params && "category" in params && typeof params.category === "string" ? params.category : null;

const { categories, recentlyUsed, search, disclaimer, localLiveApps } =
useCatalog(deeplinkInitialCategory);

return (
<TabBarSafeAreaView edges={["top", "bottom", "left", "right"]}>
{/* TODO: put under the animation header and style */}
Expand Down
5 changes: 3 additions & 2 deletions apps/ledger-live-mobile/src/screens/Platform/v2/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
useDisclaimerRaw,
useRecentlyUsed,
DisclaimerRaw,
Categories,
} from "@ledgerhq/live-common/wallet-api/react";
import { useLocalLiveAppContext } from "@ledgerhq/live-common/wallet-api/LocalLiveAppProvider/index";

Expand All @@ -25,13 +26,13 @@ import { readOnlyModeEnabledSelector } from "../../../reducers/settings";
import { NavigationProps } from "./types";
import { useManifests } from "@ledgerhq/live-common/platform/providers/RemoteLiveAppProvider/index";

export function useCatalog() {
export function useCatalog(initialCategory?: Categories["selected"] | null) {
const recentlyUsedDB = useRecentlyUsedDB();
const { state: localLiveApps } = useLocalLiveAppContext();
const allManifests = useManifests();
const completeManifests = useManifests({ visibility: ["complete"] });
const combinedManifests = useManifests({ visibility: ["searchable", "complete"] });
const categories = useCategories(completeManifests);
const categories = useCategories(completeManifests, initialCategory);
const recentlyUsed = useRecentlyUsed(combinedManifests, recentlyUsedDB);

const search = useSearch<AppManifest, TextInput>({
Expand Down
Loading