Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(live-12839): SWAP - setup demo3 flag and route #7573

Merged
merged 10 commits into from
Aug 13, 2024
Merged

feat(live-12839): SWAP - setup demo3 flag and route #7573

merged 10 commits into from
Aug 13, 2024

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Aug 12, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Added demo3 feature flag.
  • Created a new SwapWebView component to load the Swap Live app, without any legacy code.
  • Updated the feature flag logic to switch between demo1 and demo3 components for the /switch route in Electron.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested review from a team as code owners August 12, 2024 05:37
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:56pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:56pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:56pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Aug 12, 2024
@liviuciulinaru liviuciulinaru marked this pull request as draft August 12, 2024 05:38
@liviuciulinaru liviuciulinaru changed the title Feat/demo 3 feat(live-12839): SWAP - setup demo3 flag and route Aug 12, 2024
@liviuciulinaru liviuciulinaru marked this pull request as ready for review August 12, 2024 13:49
@liviuciulinaru liviuciulinaru merged commit 0c80144 into develop Aug 13, 2024
58 checks passed
@liviuciulinaru liviuciulinaru deleted the feat/demo-3 branch August 13, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallen-ledger kallen-ledger kallen-ledger approved these changes

@gre gre gre approved these changes

Assignees

@liviuciulinaru liviuciulinaru

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liviuciulinaru @gre @kallen-ledger