-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (app-data): Adds data backup and restore to install / uninstall app #7572
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
85e9d95
to
207b4ea
Compare
207b4ea
to
13e07e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for hub scope.
more general feedback beyond this PR, but the naming "Storage" is a bit generic and maybe could have been named something else since it only relates to device sdk 🤔
apps/ledger-live-desktop/src/renderer/hooks/storage-provider/useStorage.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/hooks/storageProvider/useStorage.tsx
Outdated
Show resolved
Hide resolved
13e07e3
to
fd6e5a4
Compare
fd6e5a4
to
7ae1040
Compare
Great job ! And thank you for fixing the |
7ae1040
to
a2e1adc
Compare
a2e1adc
to
57a9db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for Hub
57a9db5
to
c8c273c
Compare
✅ Checklist
npx changeset
was attached.📝 Description
This PR brings two new method in live-common for managing app install / uninstall from the device:
installAppWithRestore
: when installing an app, after, check if there is current app data in the provided storage and restore ituninstallAppWithBackup
: when deleting an app, before, check if there is current app data and save it using the given storageThe implementation makes uses of
execWithTransport
which will be the fork where we call the new method or the oldinstall
/uninstall
onesIn LLD and LLM, I implemented the new method behind the featureFlag enableAppsBackup. When enabled, it will transparently try to backup and restore app data if any.
Test Conditions
❓ Context
🧐 Checklist for the PR Reviewers