🚦 [FEAT] Create the llmMarketQuickActions feature flag
#7558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
mobile
|
|
||
| export const MarketQuickActions = () => { | ||
| const { t } = useTranslation(); | ||
| const navigation = useNavigation<StackNavigationProp<Record<string, object | undefined>>>(); |
There was a problem hiding this comment.
Suggested change
| const navigation = useNavigation<StackNavigationProp<Record<string, object | undefined>>>(); | |
| const navigation = useNavigation<StackNavigatorNavigation<BaseNavigatorStackParamList>>(); |
Should works :)
KVNLS
requested changes
Aug 8, 2024
Comment on lines
34
to
51
| const QUICK_ACTIONS = ["SEND", "RECEIVE", "BUY", "SWAP", "STAKE"] as const; | ||
| const QUICK_ACTION_DATA = { | ||
| SEND: { | ||
| name: "portfolio.quickActions.send", | ||
| }, | ||
| RECEIVE: { | ||
| name: "portfolio.quickActions.deposit", | ||
| }, | ||
| BUY: { | ||
| name: "portfolio.quickActions.buy", | ||
| }, | ||
| SWAP: { | ||
| name: "portfolio.quickActions.swap", | ||
| }, | ||
| STAKE: { | ||
| name: "portfolio.quickActions.stake", | ||
| }, | ||
| } as const; |
There was a problem hiding this comment.
Can we optimize this to only define once SEND, RECEIVE, etc...
I think that we can with something like keyof typeof.
Otherwise, maybe we can do Object.keys(QUICK_ACTION_DATA) to iterate on options.
wdyt?
There was a problem hiding this comment.
Yeah I did this but it required an extra type casting because the Object keys and entries functions type def always collapse the type of the key to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add a first draft of the MarketQuickActions hidden behind the new
llmMarketQuickActionsfeature flag.❓ Context
🧐 Checklist for the PR Reviewers